Admin action for forcing synchronization of exported API #8263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
force-pushed
the
exported-api-admin-action
branch
from
5d6a3c3 to
02c2fc6
Compare
isoos
approved these changes
Nov 11, 2024
sigurdm
reviewed
Nov 11, 2024
Contributor
sigurdm
left a comment
sigurdm
left a comment
There was a problem hiding this comment.
Is it worth creating a test of this somehow, given that we will most likely only exercise this in a state of problems...
sigurdm
reviewed
Nov 11, 2024
sigurdm
reviewed
Nov 11, 2024
| InvalidInputException.checkPackageName(p); | ||
| } | ||
| for (final p in packages) { | ||
| await apiExporter!.synchronizePackage(p, forceWrite: forceWrite); |
Contributor
There was a problem hiding this comment.
Can we do these in parallel?
Member
Author
There was a problem hiding this comment.
Let's do that in a follow up
Collaborator
I agree. I was thinking to create a few test cases where we break the bucket one way or another, and run this on it. However, it may be worth to get this out without those tests for now, as we have some coverage already of the underlying method. |
sigurdm
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope we'll never need to manually run this, but having the button is probably a good idea.